build: configure formatting, add final message#638
Closed
silverwind wants to merge 1 commit intonodejs:v1.xfrom
Closed
build: configure formatting, add final message#638silverwind wants to merge 1 commit intonodejs:v1.xfrom
silverwind wants to merge 1 commit intonodejs:v1.xfrom
Conversation
This restores the pretty-printed options output for improved readability and adds a final warning message to inform on possibly scrolled-off warnings.
bnoordhuis
pushed a commit
that referenced
this pull request
Jan 28, 2015
This restores the pretty-printed options output for improved readability and adds a final warning message to inform on possibly scrolled-off warnings. PR-URL: #638 Reviewed-By: Ben Noordhuis <[email protected]>
Member
|
@silverwind Cheers, merged in 6ad236c. I landed it under your silverwind.io name/email. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #623.
This is a follow-up on #483. It fixes the readability concern of #595 by restoring the options print to its previous pretty-printed form while adding a final print in case if warnings happened.
I also took the liberty to change the color of warnings from light red to light yellow, as I think that color is more appropriate and red should be reserved for errors only.